search

MTES-MCT / camino

Le cadastre minier numérique ouvert
https://camino.beta.gouv.fr
GNU Affero General Public License v3.0
3 stars 3 forks source link

fix(api): utilise les données des étapes pour les machines #1381

Closed MichaelBitard closed 4 months ago

MichaelBitard commented 4 months ago

2 Gros bugs corrigés en un coup...

Le premier sur la machine qui ne prenait pas en compte les données des étapes (pays, surface, date) L'autre sur TDE et la date de fin des étapes

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 53.02491% with 264 lines in your changes missing coverage. Please review.

Project coverage is 79.65%. Comparing base (fb75f83) to head (a0936d1).

Files Patch % Lines
packages/api/src/api/rest/etapes.ts 51.79% 242 Missing :warning:
...kages/api/src/tools/demarches/definitions-check.ts 0.00% 12 Missing :warning:
packages/api/src/tools/demarches/tests-creation.ts 0.00% 8 Missing :warning:
...siness/validations/titre-demarche-etat-validate.ts 86.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1381 +/- ## ======================================= Coverage 79.65% 79.65% ======================================= Files 767 767 Lines 93042 93044 +2 Branches 6532 6538 +6 ======================================= + Hits 74111 74115 +4 + Misses 18797 18795 -2 Partials 134 134 ``` | [Flag](https://app.codecov.io/gh/MTES-MCT/camino/pull/1381/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | Coverage Δ | | |---|---|---| | [api](https://app.codecov.io/gh/MTES-MCT/camino/pull/1381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `74.66% <53.02%> (+<0.01%)` | :arrow_up: | | [api-integration](https://app.codecov.io/gh/MTES-MCT/camino/pull/1381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `67.63% <52.66%> (-0.01%)` | :arrow_down: | | [api-unit](https://app.codecov.io/gh/MTES-MCT/camino/pull/1381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `33.32% <7.82%> (+<0.01%)` | :arrow_up: | | [common](https://app.codecov.io/gh/MTES-MCT/camino/pull/1381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `95.63% <ø> (ø)` | | | [ui](https://app.codecov.io/gh/MTES-MCT/camino/pull/1381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `76.26% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 0.95.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: