MTES-MCT / camino

Le cadastre minier numérique ouvert
https://camino.beta.gouv.fr
GNU Affero General Public License v3.0
3 stars 3 forks source link

feat(simplification): fusion des scl en adc #1443

Closed anis closed 2 months ago

anis commented 2 months ago

Related to #1416

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 32.89474% with 51 lines in your changes missing coverage. Please review.

Project coverage is 64.41%. Comparing base (9876549) to head (dd5fa18).

Files with missing lines Patch % Lines
...ations/20240828134125_etapes-scl-deviennent-adc.ts 0.00% 50 Missing and 1 partial :warning:

:exclamation: There is a different number of reports uploaded between BASE (9876549) and HEAD (dd5fa18). Click for more details.

HEAD has 2 uploads less than BASE | Flag | BASE (9876549) | HEAD (dd5fa18) | |------|------|------| |api|2|1| |api-integration|1|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1443 +/- ## =========================================== - Coverage 80.90% 64.41% -16.49% =========================================== Files 728 729 +1 Lines 69708 69708 Branches 6570 4958 -1612 =========================================== - Hits 56398 44904 -11494 - Misses 13217 24611 +11394 - Partials 93 193 +100 ``` | [Flag](https://app.codecov.io/gh/MTES-MCT/camino/pull/1443/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | Coverage Δ | | |---|---|---| | [api](https://app.codecov.io/gh/MTES-MCT/camino/pull/1443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `33.91% <31.08%> (-44.46%)` | :arrow_down: | | [api-integration](https://app.codecov.io/gh/MTES-MCT/camino/pull/1443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `?` | | | [api-unit](https://app.codecov.io/gh/MTES-MCT/camino/pull/1443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `33.91% <31.08%> (-0.11%)` | :arrow_down: | | [common](https://app.codecov.io/gh/MTES-MCT/camino/pull/1443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `96.56% <100.00%> (+<0.01%)` | :arrow_up: | | [ui](https://app.codecov.io/gh/MTES-MCT/camino/pull/1443/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `73.25% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

anis commented 2 months ago

Statut à ce jour : OK mais reste un titre à modifier pour rajouter un document vide à l'étape "saisine des collectivités locales" (https://camino.beta.gouv.fr/titres/m-ax-amadis-5-2022?demarcheSlug=m-ax-amadis-5-2022-oct01). En l'état du dév, si une étape "adc" existe dans la démarche, on migre les documents de la "scl" vers l"adc" existante puis on supprime la "scl", hors là il s'agit d'un cas particulier où une "adc" existe mais la "scl" n'a pas de documents, ce qui revient à simplement supprimer la "scl" (et donc perdre les infos de la date à laquelle elle a été faite.

pohayscamino commented 2 months ago

Il manque la Lettre de saisine des collectivités qui est obligatoire