MTES-MCT / camino

Le cadastre minier numérique ouvert
https://camino.beta.gouv.fr
GNU Affero General Public License v3.0
3 stars 3 forks source link

refactor(api): on fait passer les paramètres dans un objet plutôt qu'à plat #1464

Closed MichaelBitard closed 2 months ago

MichaelBitard commented 2 months ago

ils ont mis ça en place sur ma mission du vendredi, et je trouve ça plus lisible, et on peut ignorer les paramètres qu'on n'utilise pas

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 87.34177% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.83%. Comparing base (d139c9b) to head (18c22a5).

Files with missing lines Patch % Lines
packages/api/src/api/rest/administrations.ts 78.72% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1464 +/- ## ========================================== - Coverage 80.83% 80.83% -0.01% ========================================== Files 729 729 Lines 69729 69724 -5 Branches 6576 6578 +2 ========================================== - Hits 56366 56361 -5 Misses 13269 13269 Partials 94 94 ``` | [Flag](https://app.codecov.io/gh/MTES-MCT/camino/pull/1464/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | Coverage Δ | | |---|---|---| | [api](https://app.codecov.io/gh/MTES-MCT/camino/pull/1464/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `78.23% <87.17%> (-0.01%)` | :arrow_down: | | [api-integration](https://app.codecov.io/gh/MTES-MCT/camino/pull/1464/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `72.46% <87.17%> (-0.01%)` | :arrow_down: | | [api-unit](https://app.codecov.io/gh/MTES-MCT/camino/pull/1464/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `33.95% <0.00%> (+<0.01%)` | :arrow_up: | | [common](https://app.codecov.io/gh/MTES-MCT/camino/pull/1464/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `96.56% <ø> (ø)` | | | [ui](https://app.codecov.io/gh/MTES-MCT/camino/pull/1464/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT) | `73.23% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTES-MCT#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.