search

MTG-Commander-Website / MTGCommander

MTG Commander website
0 stars 0 forks source link

BUG: plugin works locall but not on server again. #19

Open Shoe2 opened 4 years ago

GavinDuggan commented 4 years ago

I see a couple of weird things... what looks like the "art" space above each post is an empty/broken placeholder, with the title from a random testing post I created? Any idea where it's getting that text from?

Shoe2 commented 4 years ago

So, the art space doesn't skew smaller images. If the aspect ratio is wrong, it fills the rest wit that gray stuff. That's just how this theme handles smaller images and ones with incorrect aspect ratios as far as I can tell. I dont see any titles like you are describing. I'll fish around and see if I can replicate. Do toy have a screenshot?

On Wed, Dec 18, 2019, 9:44 PM GavinDuggan notifications@github.com wrote:

I see a couple of weird things... what looks like the "art" space above each post is an empty/broken placeholder, with the title from a random testing post I created? Any idea where it's getting that text from?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/MTG-Commander-Website/MTGCommander/issues/19?email_source=notifications&email_token=ABURNG3WHMHAB2ZZDH4X33DQZMC5JA5CNFSM4J4RYI42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHIPTBI#issuecomment-567343493, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABURNG3PP5CYBRDE6C5GYFLQZMC5JANCNFSM4J4RYI4Q .

Shoe2 commented 4 years ago

I see it now. The text thing is a bug in my code. I will tweak

On Thu, Dec 19, 2019, 9:21 AM Andrew Lee andrewelee1983@gmail.com wrote:

So, the art space doesn't skew smaller images. If the aspect ratio is wrong, it fills the rest wit that gray stuff. That's just how this theme handles smaller images and ones with incorrect aspect ratios as far as I can tell. I dont see any titles like you are describing. I'll fish around and see if I can replicate. Do toy have a screenshot?

On Wed, Dec 18, 2019, 9:44 PM GavinDuggan notifications@github.com wrote:

I see a couple of weird things... what looks like the "art" space above each post is an empty/broken placeholder, with the title from a random testing post I created? Any idea where it's getting that text from?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/MTG-Commander-Website/MTGCommander/issues/19?email_source=notifications&email_token=ABURNG3WHMHAB2ZZDH4X33DQZMC5JA5CNFSM4J4RYI42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHIPTBI#issuecomment-567343493, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABURNG3PP5CYBRDE6C5GYFLQZMC5JANCNFSM4J4RYI4Q .

Shoe2 commented 4 years ago

So that is a big, but also, it's because the feeds generator isn't working on the server again. This was the file that was generated on my local box.

What did you find again that made things work on the server that was different? I forget

On Thu, Dec 19, 2019, 9:36 AM Andrew Lee andrewelee1983@gmail.com wrote:

I see it now. The text thing is a bug in my code. I will tweak

On Thu, Dec 19, 2019, 9:21 AM Andrew Lee andrewelee1983@gmail.com wrote:

So, the art space doesn't skew smaller images. If the aspect ratio is wrong, it fills the rest wit that gray stuff. That's just how this theme handles smaller images and ones with incorrect aspect ratios as far as I can tell. I dont see any titles like you are describing. I'll fish around and see if I can replicate. Do toy have a screenshot?

On Wed, Dec 18, 2019, 9:44 PM GavinDuggan notifications@github.com wrote:

I see a couple of weird things... what looks like the "art" space above each post is an empty/broken placeholder, with the title from a random testing post I created? Any idea where it's getting that text from?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/MTG-Commander-Website/MTGCommander/issues/19?email_source=notifications&email_token=ABURNG3WHMHAB2ZZDH4X33DQZMC5JA5CNFSM4J4RYI42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHIPTBI#issuecomment-567343493, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABURNG3PP5CYBRDE6C5GYFLQZMC5JANCNFSM4J4RYI4Q .

GavinDuggan commented 4 years ago

Before I make any changes on the host, can we set it up to sync the plugin file from the repo here so we can pull/push that, and avoid losing all the changes on the host again?

Shoe2 commented 4 years ago

It wasn't that we lost changes, it was that I had to rewrite things to make the sort feature work, but yeah, we can do that.

Do you know how off hand? I can research if you dont.

On Thu, Dec 19, 2019, 5:35 PM GavinDuggan notifications@github.com wrote:

Before I make any changes on the host, can we set it up to sync the plugin file from the repo here so we can pull/push that, and avoid losing all the changes on the host again?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/MTG-Commander-Website/MTGCommander/issues/19?email_source=notifications&email_token=ABURNG3AAUGDLNI52VK7KGDQZQONFA5CNFSM4J4RYI42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHLS3FI#issuecomment-567750037, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABURNGZNJSD5F55XSCH2F2DQZQONFANCNFSM4J4RYI4Q .

GavinDuggan commented 4 years ago

Ok, so the staging directory is now a git repository, and can be synched as a normal. I've created an SSH key for you on the host, and configured the global git settings, but you'll need to add the pubkey to your github settings. We can do it tomorrow during sync.

I'll figure out what's wrong with the plugin.