Check if all rests have consistent names

MTG / SymbTr

Turkish Makam Music Symbolic Data Collection

Other

82 stars 12 forks source link

Check if all rests have consistent names #12

Closed sertansenturk closed 9 years ago

sertansenturk commented 9 years ago

even though all the "Sus" and "Es" might have been merged in v2.2, there might still be letfover or rests indicated with an empty string. Make an automatic checker for it.

burakuyar commented 9 years ago

In the symbtr documentation (excel file), it is stated that the Kod0 indicates rests. However, almost all rests have Kod9 in txt files. Is this something to be fixed in the files or ini the excel doc?

sertansenturk commented 9 years ago

Good point! The current version says Kod9 is also for rests. I have to consult it with Kemal. But since all the rests have Kod9 in the collection (it's being checked after symbtrdataextractor/commit/c9a31d0f73654f11b926334880656bc6f4a5dee7 called by extras/unittests/validatetxtcontent.py using travis ci), we can safely assume Kod9 is correct for rests.