search

MTG / acousticbrainz-client

A client to upload data to an acousticbrainz server
GNU General Public License v3.0
29 stars 22 forks source link

Check that python setup.py install works on windows #30

Open alastair opened 10 years ago

alastair commented 10 years ago

Especially the bit where it copies the extractor. To make distro packages easier we might not want to actually install this anyway.

JonnyJD commented 10 years ago

According to this mail, it doesn't: http://lists.musicbrainz.org/pipermail/musicbrainz-devel/2014-October/005902.html

Not installing the extractor when running install on abzsubmit sounds like a good option. On (Arch) Linux I just remove that part from setup.py with sed. For Windows and Mac providing a package with "embedded" extractor and libs is possibly the better choice.

For isrcsubmit I do some packaging for Windows and Mac: https://github.com/JonnyJD/musicbrainz-isrcsubmit/blob/master/pkg/Makefile I just fetch the dependencies (in binary form) with wget, put them at appropriate places and zip it up.

alastair commented 10 years ago

Yeah, my plan for windows was going to be an "all in one installer". We're closer to this now that we bundle requests.

On 28 October 2014 17:10, Johannes Dewender notifications@github.com wrote:

According to this mail, it doesn't:

http://lists.musicbrainz.org/pipermail/musicbrainz-devel/2014-October/005902.html

Not installing the extractor when running install on abzsubmit sounds like a good option. On (Arch) Linux I just remove that part from setup.py with sed. For Windows and Mac providing a package with "embedded" extractor and libs is possibly the better choice.

For isrcsubmit I do some packaging for Windows and Mac: https://github.com/JonnyJD/musicbrainz-isrcsubmit/blob/master/pkg/Makefile I just fetch the dependencies (in binary form) with wget, put them at appropriate places and zip it up.

— Reply to this email directly or view it on GitHub https://github.com/MTG/acousticbrainz-client/issues/30#issuecomment-60782201 .

JonnyJD commented 9 years ago

The last mail in that ML dialog indicates the workaround (without installing) works: http://lists.musicbrainz.org/pipermail/musicbrainz-devel/2014-October/005909.html

So copying having streaming_extractor_music.exe in the same directory as abzsubmit and then calling python abzsubmit <directory> works (if python is in PATH).

Making an abzsubmit zip with streaming_extractor_music already in place would be a step forward right now for people to test things.