Closed sertansenturk closed 9 years ago
For recordings with no works we should continue to use tags
On 28 January 2015 at 17:56, Sertan Senturk notifications@github.com wrote:
Right now these three are saved as tags either in the recordings or in the works. They have to be added to work attributes. We already have the list of names, but we have to confirm them with Kemal Karaosmanoglu. Moreoever we have to decide how to add them to recordings which do not have any work (e.g. improvisations)
— Reply to this email directly or view it on GitHub https://github.com/MTG/dunya/issues/170.
To submit this data to musicbrainz we need an attribute name ("Makam"? We use 'Carnatic Raaga', etc) and an ordered list of all values that are in that attribute. Then I'll submit it, and we can work on the script to automatically convert tags to attributes.
I agree with the recordings with no works. Additionally for audio recordings with multiple performances we can split the track metadata as done in http://musicbrainz.org/release/732f33fc-c373-46d2-a09a-545c03469766. This way we can avoid confusions due to the current sequence of tags (e.g. form2, makam3) too.
Regarding the lists I remember we put them somewhere a year ago. Do you remember where they are? Otherwise we have these three lists:
s3.amazonaws.com/teambox-assets/assets/230490/original/Usuls_Alphabetic.txt?AWSAccessKeyId=AKIAI4IWKKLUGH6MVPQA&Expires=1477472523&Signature=1aad%2BSUk4nMWxkuo8MDqsmw9vlg%3D
s3.amazonaws.com/teambox-assets/assets/230493/original/forms_Alphabetic.txt?AWSAccessKeyId=AKIAI4IWKKLUGH6MVPQA&Expires=1477472521&Signature=bvpMUiHBC6gtUJxRB5uMcauKOPA%3D
I remember seeing them, but can't find them in my email. Let's work from this list
Just to confirm: We are going to ask Kemal these right?
If there's nothing else, I'll send him an email right away..
Yes, that's a good list to ask
I think as well it is good list. I think the tag should be called "turkish makam" to disambiguate from the MAQAM used in arabic music tradition. IMHO the lists should be as extensive as possible, but as well not too cumbersome for our purposes. From this perspective, "Segâh (Çargâh'ta)" is better than "Segâh" because it can be used as ground truth for tonic identification, but then it should be in formatting easy to work with like .e.g. "Segâh-Çargâh'ta"
Kemal has just replied to my mail:
He also quickly went through the documents and said there is no need to change anything else.
I prepared the documents according to these comments:
We should also check whether the current makam, usul and form tags in Musicbrainz have any extras (and aliases) or not.
@alastair mentioned that we can add the mertebe and transposition information too. I will prepare a list before we submit the proposal to MusicBrainz people.
Can you please put these three spreadsheets in the "Makam lists" sheet in CompMusic/Dunya in drive (where the instruments list is)
Done!
Data is added to musicbrainz. 2 more tasks remain - #203, to add missing works, and also migrate our data from tags (or from mu2 files??) to works that already exist in musicbrainz.
@andrebola will work on copying existing tags to work attributes.
makam.models.Work.objects.all()
, or by scraping musicbrainz (get all releases in the collection, get all recordings in the release, get all works of the recordings)docserver.models.SourceFile
with SourceFileType
= symbtrmu2
and a Document
with external_identifier
set to the work mbidNote that there may not always be a mu2 file for a work that is in musicbrainz. In this situation we should only look at tags from works and recordings.
I have a quick question, previously we talked about adding mertebe and transposition (mentioned in https://github.com/MTG/dunya/issues/170#issuecomment-72939597 and https://github.com/MTG/dunya/issues/170#issuecomment-73089471) information to usul and makam attributes, repectively. Will it be added to MusicBrainz later or is it dropped?
ah - we forgot about it, and they weren't in the spreadsheet. We can request for them to be added later.
On 10 June 2015 at 15:16, Sertan Senturk notifications@github.com wrote:
I have a quick question, previously we talked about adding mertebe and transposition (explained in #170 (comment) https://github.com/MTG/dunya/issues/170#issuecomment-72939597) : #170 (comment) https://github.com/MTG/dunya/issues/170#issuecomment-73089471 information to usul and makam attributes, repectively. Will it be added to MusicBrainz later or is it dropped?
— Reply to this email directly or view it on GitHub https://github.com/MTG/dunya/issues/170#issuecomment-110746832.
Me too! I opened a separate issue for mertebe and transpositions: https://github.com/MTG/dunya/issues/214
Done
Right now these three are saved as tags either in the recordings or in the works. They have to be added to work attributes. We already have the list of names, but we have to confirm them with Kemal Karaosmanoglu. Moreoever we have to decide how to add them to recordings which do not have any work (e.g. improvisations)