MTG / essentia.js

JavaScript library for music/audio analysis and processing powered by Essentia WebAssembly
https://essentia.upf.edu/essentiajs
GNU Affero General Public License v3.0
645 stars 42 forks source link

Python3 migration & Emscripten update #133

Closed jmarcosfer closed 7 months ago

jmarcosfer commented 8 months ago

Two main changes to the build pipeline before other development tasks:

Notes:

jmarcosfer commented 8 months ago

@albincorreya let me know what you think about the 2 notes in question, please

jmarcosfer commented 8 months ago

The new default compiling method looks clean. Is there any major performance difference between these methods?

I assume we will migrate the python scripts to python3 in another PR?

I don't see any noticeable performance difference between the two methods, so I'll stick to the newer default way, which also looks cleaner as you say :) The change to Python3 should be included in this PR, that was the initial goal of this PR, but then along the way I found I should update Emscripten too. I guess it's okay to include the two as updating the build pipeline.