CI/CD migration - Githubissues

MTG / essentia.js

JavaScript library for music/audio analysis and processing powered by Essentia WebAssembly

https://essentia.upf.edu/essentiajs

GNU Affero General Public License v3.0

628 stars 41 forks source link

CI/CD migration #72

Closed jmarcosfer closed 2 years ago

jmarcosfer commented 2 years ago

Addresses issue #63

Changes:

Travis config has been removed
Added an integration workflow that uses Github Actions to build the library on every push or PR open/edit to branches dev or master
Added an example deploy workflow (which, for now, just temporarily uploads the builds to transfer.sh) to run on PR closed on dev and master

Discussion:

Unsure about cpp setup to mimick language: cpp line on travis.yml file. Commented it for now, since I assume cpp setup is already done in docker image.

albincorreya commented 2 years ago

LGTM @jmarcosfer. Btw, were you able to run successful job in actions with the current branch. Checking here seems like the last job was failed.

jmarcosfer commented 2 years ago

LGTM @jmarcosfer. Btw, were you able to run successful job in actions with the current branch. Checking here seems like the last job was failed.

Yes, the failed job is from the first time I pushed, the path for one of the uses fields was wrong, but should be corrected already. In any case, I'll try running these workflows locally with https://github.com/nektos/act and confirm that everything's working fine. Then I'll comment here and close the PR. Thanks for the review!

albincorreya commented 2 years ago

@jmarcosfer One last thing, it would be nice to replace the 'build passing' badge in README with github action status instead of travis. Perhaps this could be a way of doing it. I guess, there might be lot of alternatives out there.

jmarcosfer commented 2 years ago

Eventually the deploy.yml workflow (which currently just builds the project like the integration workflow does and puts it on transfer.sh) could be setup to publish the library on the npm site and CDNs triggered by a release event on master.

albincorreya commented 2 years ago

Eventually the deploy.yml workflow (which currently just builds the project like the integration workflow does and puts it on transfer.sh) could be setup to publish the library on the npm site and CDNs triggered by a release event on master.

@jmarcosfer Yes, I agree. It would be nice setup that too. I see you already have some some in ci directory. Perhaps we can also add that script to the deploy.yml workflow.

Regarding, publishing to NPM can be setup as it only works with a manual trigger step in the pipeline (no automatic push).