MTG / essentia.js

JavaScript library for music/audio analysis and processing powered by Essentia WebAssembly
https://essentia.upf.edu/essentiajs
GNU Affero General Public License v3.0
645 stars 42 forks source link

Migrate CI/CD to Github actions, fix broken links examples #80

Closed albincorreya closed 2 years ago

albincorreya commented 2 years ago

This PR addresses mainly the changes related to the migration of CI/CD to GitHub actions and fix broken links in the example web demos.

Cheers to @jmarcosfer for the contributions :)

netlify[bot] commented 2 years ago

✔️ Deploy Preview for essentiajs-pitchmelodia ready!

🔨 Explore the source changes: ed74d7240b84b24074f62b592c9aace517c80c5c

🔍 Inspect the deploy log: https://app.netlify.com/sites/essentiajs-pitchmelodia/deploys/61a3f3638960da00081217bf

😎 Browse the preview: https://deploy-preview-80--essentiajs-pitchmelodia.netlify.app

netlify[bot] commented 2 years ago

✔️ Deploy Preview for essentiajs-melspectrogram ready!

🔨 Explore the source changes: ed74d7240b84b24074f62b592c9aace517c80c5c

🔍 Inspect the deploy log: https://app.netlify.com/sites/essentiajs-melspectrogram/deploys/61a3f363b862e80007a15056

😎 Browse the preview: https://deploy-preview-80--essentiajs-melspectrogram.netlify.app

albincorreya commented 2 years ago

@jmarcosfer Sure that is also fine. We can also make a new PR for adding the new audio problem detection demo from @ljoglar :) Since this PR is mostly related to CI/CD migration and some other minor fixes to existing examples, I think it would be good to separate both additions in different PR. If we have to wait to add anything related to CI/CD, we can keep the PR open.

albincorreya commented 2 years ago

@jmarcosfer Btw, I just noticed that there are no pipelines running on any changes on the dev branch as I can see here. According to your setting, shouldn't it do that? Am I missing anything here?

jmarcosfer commented 2 years ago

@albincorreya Nope. Workflows only run on changes to source code or build config, and I don't think there have been any changes to /src or any of the main configuration files.

albincorreya commented 2 years ago

@jmarcosfer That make sense. Thanks for the clarification :)