search

MTG / essentia

C++ library for audio and music analysis, description and synthesis, including Python bindings
http://essentia.upf.edu
GNU Affero General Public License v3.0
2.85k stars 533 forks source link

Rename BpmHistogram #350

Open dbogdanov opened 8 years ago

dbogdanov commented 8 years ago

The algorithm estimates beat positions and BPM-based descriptors. Good name should provide hints that the algorithm is based on NoveltyCurve. Current name of the algorithm is misleading and can be confused with BpmHistogramDescriptors, that computes BPM histogram given a list of BPM intervals.

Candidates:

dbogdanov commented 8 years ago

After revising this algorithm I can conclude it is somewhat useful and can be recovered from the "outdated" status after further revision and evaluation. The algorithm was designed for use with NoveltyCurve, but it is more generic than that because it can be used with other onset detection functions too (although we have no information about its performance in this case).

Still we can find a better name representing the approach. We also need to compare the functionality with the BpmHistogramDescriptors algorithm as there can be some confusion.