search

MTG / essentia

C++ library for audio and music analysis, description and synthesis, including Python bindings
http://essentia.upf.edu
GNU Affero General Public License v3.0
2.81k stars 525 forks source link

[Android] wscript only considers arm architecture #760

Open alexsivris opened 6 years ago

alexsivris commented 6 years ago

Hello!

So I wanted to compile essentia for all Android architectures (x86, x86_64, arm, arm64) and I noticed that the file wscript has hardcoded values for cross compilation. Specifically, looking at the file wscript in the master branch at lines 223 - 225, we see the hardcoded value arm-linux-androideabi-*. I worked around this issue by manually changing these values depending on the wanted architecture, for example:

These definitions are taken from the "prefix" of the files located in the bin/ folder of your toolchain. Now, this could be solved by automatically building all architectures, for example.

dbogdanov commented 5 years ago

Sure, we should address that. Any pull request is welcome.

techiespace commented 5 years ago

After switching to clang in #622 how can we change the architectures for Android?

amCap1712 commented 4 years ago

With Android NDkr21 and above, there are scripts available in the NDK to configure which architecture to build for. I suggest adding a flag to wscript to choose the architecture.