search

MTG / gaia

C++ library to apply similarity measures and classifications on the results of audio analysis, including Python bindings. Together with Essentia it can be used to compute high-level descriptions of music.
http://essentia.upf.edu
GNU Affero General Public License v3.0
271 stars 66 forks source link

QT5.11 / C++11 changes #101

Closed alastair closed 2 years ago

alastair commented 4 years ago

92 upgraded to QT 5.9, in Ubuntu 18.04.

QT5.11 in Debian 10 requires c++11, this should be changed in the waffile

When upgrading to C++11, gvarlengtharray.h fails to compile because of the use of memcpy. I see that this file appears to be an almost direct copy of qvarlengtharray from QT, and then renamed q->g. I'm not sure why it's been copied into the gaia code and renamed. @dbogdanov do you have any idea about this? It seems like we could just directly use qvarlengtharray here

We should also check on the latest QT, 5.14.

alastair commented 4 years ago

There are also a number of warnings now emitted by c++11 compilers, and additional warnings by newer versions of gcc and clang. We should aim to have 0 warnings during gaia compilation.

dbogdanov commented 4 years ago

Related to gvarlengtharray.h, at that time, there was some bug in QT 4.6 and for that reason a static version of QVarLengthArray from 4.5.3 was included into the source tree. This should be irrelevant now.