search

MTG / gaia

C++ library to apply similarity measures and classifications on the results of audio analysis, including Python bindings. Together with Essentia it can be used to compute high-level descriptions of music.
http://essentia.upf.edu
GNU Affero General Public License v3.0
271 stars 66 forks source link

ClassificationResults can distinguish between classifier types, but isn't needed #99

Closed alastair closed 2 years ago

alastair commented 4 years ago

https://github.com/MTG/gaia/blob/ec8afc589d7d70b84450ba1a400da7bd684808da/src/bindings/pygaia/scripts/classification/get_classification_results.py#L29

There is this parameter classifierType which is used to distinguish between the type of classifier, but we only have svm in gaia. We should remove this parameter unless we absolutely know that we're going to add more classifiers.

alastair commented 4 years ago

also, it seems like the filterResults method isn't used. Remove if it unneeded.

dbogdanov commented 2 years ago

This has been addressed in e0d8274e81180113250ed636690b8508eccd8f7d.