MTG / homebrew-essentia

Homebrew build scripts for Essentia
34 stars 13 forks source link

Fix: essentia on apple silicon #36

Open Amar1729 opened 11 months ago

Amar1729 commented 11 months ago

Fixes #30, fixes #32, fixes #33

The misconception in the linked issue description is that depends_on "numpy" should install numpy bindings, which essentia requires. However, homebrew's current numpy no longer supports python3.9, which is why the build was failing to find numpy. That is also why running python3.9 -m pip install numpy will allow essentia to build properly, although it is generally not recommended to install python modules to a homebrew python distribution manually.

Instead, I've done the following:

Note that the formulae i've extracted from homebrew-core are just the most recent versions that had depends_on "python@3.9". Newer versions of libcython and numpy support 3.9 but I didn't want to extract the current version and have to backport it in case there were other changes.

slight note: i think that --with-gaia bindings might be broken/not fully working, since that formula uses python@3.8. I can submit a pr later that will update that.

zumpchke commented 4 months ago

@dbogdanov Can this be merged?