search

MTG / metadb

A simple database containing metadata linked to musicbrainz ids
8 stars 7 forks source link

MusicBrainz Scraper method added #4

Closed kosmasK closed 8 years ago

kosmasK commented 8 years ago

It is not the final version. It can be updated in order to filter the responses fro the API requests and format the output to JSON.

kosmasK commented 8 years ago

I will commit tomorrow the rest of the additions. Is it more or less what you expected? p.s. $ vagrant halt for shutting down vagrant vm without destroying the image: https://www.vagrantup.com/docs/cli/halt.html

alastair commented 8 years ago

This is a really good start.

kosmasK commented 8 years ago

Updated version based on your comments, plus an addition for the release-group info.

alastair commented 8 years ago

This is looking good. You're missing tags, but otherwise I think everything is a good fit

kosmasK commented 8 years ago

almost finished but I am having an error which I believe is a bug on the get_release_by_id() because it does not support the "tags" include, even though the ws2 is responding to that include! For instance this is not supported: mb.get_release_by_id("de70f1dc-cf1d-4fcd-a279-4d6d0026483c", includes = ["artists", "release-groups", "tags"])

but this is supported: http://musicbrainz.org/ws/2/release/de70f1dc-cf1d-4fcd-a279-4d6d0026483c?inc=artists+release-groups+tags

alastair commented 8 years ago

You could try and install the development version of the musicbrainz library:

pip install -e git+https://github.com/alastair/python-musicbrainz-ngs.git@master#egg=musicbrainzngs-dev
kosmasK commented 8 years ago

It works!

alastair commented 8 years ago

Thanks, I've merged it!