search

MTG / sms-tools

Sound analysis/synthesis tools for music applications
https://www.upf.edu/web/mtg/sms-tools
GNU Affero General Public License v3.0
1.63k stars 751 forks source link

Sms tools package #110

Closed cvf-bcn-gituser closed 3 years ago

cvf-bcn-gituser commented 3 years ago

See line 177 of harmonicModel.py inside function harmonicModelAnal if the condition "while pin<=pend: ", is not satisfied then there will be an error on line 200

This error can occur if someone passes a normal array instead of a numpy array. This type of practice of returning "xhfreq" but its olny declared in while llop should be avoided. (What if While loop condition never satisfied?)

xserra commented 3 years ago

This is not a proper pull request