bug fixes to StructuredGrid3D.from_ws3dinv

alkirkby commented 4 months ago

Description

bug fixes to ensure nodes_east, nodes_north and nodes_z get read in correctly

Motivation and Context

These attributes are now properties so couldn't be set directly

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov[bot] commented 4 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (7bee1c1) 27.05% compared to head (17ea7dd) 27.04%.

Files	Patch %	Lines
mtpy/modeling/structured_mesh_3d.py	0.00%	14 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #18 +/- ## ========================================== - Coverage 27.05% 27.04% -0.01% ========================================== Files 128 128 Lines 21785 21791 +6 ========================================== Hits 5893 5893 - Misses 15892 15898 +6 ``` | [Flag](https://app.codecov.io/gh/MTgeophysics/mtpy-v2/pull/18/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTgeophysics) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/MTgeophysics/mtpy-v2/pull/18/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTgeophysics) | `27.04% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MTgeophysics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kujaku11 commented 4 months ago

@alkirkby Let me know when you think this pull request is ready, and I can review and accept it.

alkirkby commented 4 months ago

Hi @kujaku11 - I think this is ready for review. Thanks

MTgeophysics / mtpy-v2