Gis tools clean up - Githubissues

kujaku11 commented 4 years ago

Description

Cleaned up gis_tools by:

Testing for GDAL version if 3 or newer lat and lon switched internally on input
Removed deprecated functions that used the original methods
Split up main functions into smaller functions for clarity and easier testing
Updated functions so a user can input various formats of lat and lon ['DD:mm:ss.ms', 'DD.decimal', float]
Updated projection functions to project a single point or multiple points
Multiple points can be input in various formats
Added documentation in the sphinx format
Updated tests

Motivation and Context

This module has always been a bit of hack and bandaged when thing broke. Hopefully this cleans it up and makes it more robust.

How Has This Been Tested?

Developed a decently comprehensive test, all pass

Runs on Python 3.4 and higher

Screenshots (if appropriate):

Types of changes

[ ] Fixed change with newer versions of GDAL
[ ] Added ability for users to input various formats of lat and lon
[ ] Breaking change (fix or feature that would cause existing functionality to change) None that I can detect yet

Checklist:

[ x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x ] I have updated the documentation accordingly.
[ x] I have added tests to cover my changes.
[x ] All new and existing tests passed.

alkirkby commented 4 years ago

Just tested the branch - did you update how the vertical mesh is generated in creating a modem model? I am now getting a different vertical mesh when I make a new model

kujaku11 commented 4 years ago

I don't think so, what does it look like?

On Tue, May 12, 2020, 5:35 PM Alison Kirkby notifications@github.com wrote:

Just tested the branch - did you update how the vertical mesh is generated in creating a modem model? I am now getting a different vertical mesh when I make a new model

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MTgeophysics/mtpy/pull/108#issuecomment-627672873, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQA5BWEK3QTV7ZRMHUDDJDRRHTLXANCNFSM4MZ3AQCQ .