search

MTrab / danfoss_ally

Danfoss Ally integration for Home Assistant
GNU General Public License v3.0
44 stars 10 forks source link

Use of deprecated symbols and functions #153

Open pwuersch opened 3 months ago

pwuersch commented 3 months ago

Describe the issue

Hi, thanks a lot for this very well working extension. I really love to have the integration of Danfoss Ally devices in my Homeassistant with such an easy setup.

However, I get a lot of warnings coming from the danfoss_ally integration. Since the HA requirement is anyway set to quite a recent release, I think this can already be fixed without breaking existing functionality. Here are the details:

async_forward_entry_setup

Detected code that calls async_forward_entry_setup for integration danfoss_ally with title: Danfoss Ally and entry_id: be5b075bb1019362c0d68eef8ad9f830, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.

HVAC stuff

CURRENT_HVAC_IDLE was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACAction.IDLE instead, please report it to the author of the 'danfoss_ally' custom integration
HVAC_MODE_AUTO was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.AUTO instead, please report it to the author of the 'danfoss_ally' custom integration
HVAC_MODE_HEAT was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.HEAT instead, please report it to the author of the 'danfoss_ally' custom integration
HVAC_MODE_COOL was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.COOL instead, please report it to the author of the 'danfoss_ally' custom integration
HVAC_MODE_OFF was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.OFF instead, please report it to the author of the 'danfoss_ally' custom integration

Let me know if you would be open to PRs on this topic as I would like to contribute where I can.

What version of Home Assistant Core has the issue?

core-2024.7.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Diagnostics information

No response

Anything in the logs that might be useful for us?

2024-07-31 14:27:46.946 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'danfoss_ally' calls async_forward_entry_setup for integration, danfoss_ally with title: Danfoss Ally and entry_id: be5b075bb1019362c0d68eef8ad9f830, which is deprecated and will stop working in Home Assistant 2025.6, await async_forward_entry_setups instead at custom_components/danfoss_ally/__init__.py, line 160: hass.async_create_task(, please create a bug report at https://github.com/MTrab/danfoss_ally/issues
2024-07-31 14:27:48.337 WARNING (ImportExecutor_0) [homeassistant.components.climate.const] HVAC_MODE_AUTO was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.AUTO instead, please report it to the author of the 'danfoss_ally' custom integration
2024-07-31 14:27:48.340 WARNING (ImportExecutor_0) [homeassistant.components.climate.const] HVAC_MODE_HEAT was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.HEAT instead, please report it to the author of the 'danfoss_ally' custom integration
2024-07-31 14:27:48.342 WARNING (ImportExecutor_0) [homeassistant.components.climate.const] HVAC_MODE_COOL was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.COOL instead, please report it to the author of the 'danfoss_ally' custom integration
2024-07-31 14:27:48.344 WARNING (ImportExecutor_0) [homeassistant.components.climate.const] HVAC_MODE_OFF was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.OFF instead, please report it to the author of the 'danfoss_ally' custom integration
2024-07-31 14:27:48.355 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration danfoss_ally with title: Danfoss Ally and entry_id: be5b075bb1019362c0d68eef8ad9f830, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
2024-07-31 14:27:48.366 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration danfoss_ally with title: Danfoss Ally and entry_id: be5b075bb1019362c0d68eef8ad9f830, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
2024-07-31 14:27:48.368 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration danfoss_ally with title: Danfoss Ally and entry_id: be5b075bb1019362c0d68eef8ad9f830, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
2024-07-31 14:27:48.370 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration danfoss_ally with title: Danfoss Ally and entry_id: be5b075bb1019362c0d68eef8ad9f830, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.

Additional information

No response

JardaProchazka commented 2 weeks ago

I have the same problem. Great integration, solution please Home Assistant Core2024.10.3 Supervisor 2024.10.2 Operating System13.1

CURRENT_HVAC_IDLE was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACAction.IDLE instead, please report it to the author of the 'danfoss_ally' custom integration HVAC_MODE_AUTO was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.AUTO instead, please report it to the author of the 'danfoss_ally' custom integration HVAC_MODE_HEAT was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.HEAT instead, please report it to the author of the 'danfoss_ally' custom integration HVAC_MODE_COOL was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.COOL instead, please report it to the author of the 'danfoss_ally' custom integration HVAC_MODE_OFF was used from danfoss_ally, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.OFF instead, please report it to the author of the 'danfoss_ally' custom integration

MTrab commented 2 weeks ago

This is only a deprecation warning - not a serious issue for the rest of the year. I'll issue an update when I get around to this