search

MTrab / energidataservice

Fetches spot prices from Energi Data Service
GNU General Public License v3.0
194 stars 27 forks source link

Do not verify API SSL #565

Closed MTrab closed 3 months ago

MTrab commented 3 months ago

To fix API SSL certificate validity errors/issues, disable SSL verification

henriknj commented 3 months ago

@MTrab I've reached out to Energinet about this and the issue seems to have been resolved now. The intermediate certificate is now send by their server, so you can revert this change.

I have opened a MR https://github.com/MTrab/energidataservice/pull/570

henriklund commented 3 months ago

@MTrab, it may be worth considering if a configuration should be added allowing the enduser to actively deactivate SSL validation - should such a case like this occur in the future.

exetico commented 3 months ago

I agree with @henriklund ; make it optional, as part of the configuration. Pushing a update to simply ignore the API SSL validation are a bit... odd, even though Energinet was facing some issues with the certs (possibly?).

henriknj commented 3 months ago

Lets just get this change reverted, then we deal with adding a configuration option later.

MTrab commented 3 months ago

Will look into this when back from holiday - nothing will happen for at least one week