MTrab / pyworxcloud

PyPI module for integrating with Worx Cloud devices
GNU General Public License v3.0
22 stars 19 forks source link

asyncio really needed? #4

Closed henfri closed 3 years ago

henfri commented 3 years ago

Hello,

thanks for sharing pyworxcloud! I intend to use it for smarthomeng.de. Unfortunately, I fear that combining the two is difficult, as smarthomeng is threaded, whereas pyworxcloud uses asyncio.

I wonder, if it is really required to use asyncio. I see that it is used only:

So, I wonder if it is really required to use asyncio in the library?

Best regards, Hendrik

henfri commented 3 years ago

Hello again,

I have tested the removal of asyncio. It seems to work fine. The changes I had to make were very minimal...

I could make a PR, but I suppose you have a reason why you used asyncio in the library (instead of where using the API (landroid_cloud).

What's your view on this?

Best regards, Hendrik

MTrab commented 3 years ago

AsyncIO have been removed in latest version