MTrop / DoomTools

Doom-related tools for Java. Home of DECOHack and lots of other utilities. Build WAD projects (and soon, other kinds) with ease!
https://mtrop.github.io/DoomTools/
MIT License
46 stars 5 forks source link

[DECOHack] Output warning/error on zero-mass things? #103

Closed biwa closed 12 months ago

biwa commented 12 months ago

Shootable zero-mass things cause most ports to crash: https://www.doomworld.com/forum/topic/141168-i_signalhandler-8-error/

DECOHack does not complain about zero-mass things, but maybe it'd be a good idea if it did.

MTrop commented 12 months ago

Seems easy enough. Though I wonder if it should be a warning rather than an error.

biwa commented 12 months ago

I think a warning would be fine. Maybe there's a reason why someone wants zero-mass things. This also only seems to affect shootable things, so maybe DECOHack could check for that. It could also set the missing mass to 100, which seems to be the default for most non-interactive things.

MTrop commented 12 months ago

I opted to just warn the user. Setting the mass should not be done automatically.

Added in commit 459a0253024ab9dba59bbc337a0d343767fe41af