search

MTrop / DoomTools

Doom-related tools for Java. Home of DECOHack and lots of other utilities. Build WAD projects (and soon, other kinds) with ease!
https://mtrop.github.io/DoomTools/
MIT License
46 stars 5 forks source link

[DECOHack] Safeguard/Warning Against Spawning Non-MISSILE Projectiles #77

Closed MTrop closed 2 years ago

MTrop commented 2 years ago

Via Hobomaster at DoomWorld: https://www.doomworld.com/forum/topic/118074-dsda-doom-source-port-v0243/?do=findComment&comment=2519618

"...if you use WeaponProjectile to spawn something that doesn't have the MISSILE flag, the speed is incorrect. This is a strange dehacked quirk where the speed is only supposed to be fixed point if it has the MISSILE flag (lol dehacked?)"

"LOL DeHackEd" indeed, however this is not unintended behavior - things flagged as MISSILE would have the correct values for projectiles that are spawned.

Still, DECOHack could stand to be a bit smarter and warn the user that they are going to spawn a thing that is not a MISSILE. This is an entirely possible check given that the index is known and the parameter is already being checked to be an appropriate "Thing" index.

MTrop commented 2 years ago

Added in commit 40bbb924d2c0804be2aa2084564a0653ae35566b