MTrop / DoomTools

Doom-related tools for Java. Home of DECOHack and lots of other utilities. Build WAD projects (and soon, other kinds) with ease!
https://mtrop.github.io/DoomTools/
MIT License
46 stars 5 forks source link

[DECOHack] MonsterInfighting Miscellany Entry not Named Clearly #82

Closed punchyouinthefaceman closed 2 years ago

punchyouinthefaceman commented 2 years ago

Having a section like:

misc
{
    monsterInfighting false
}

will output a valid patch but be missing the monster infighting entry (so in this case there would be no misc section in the resulting .deh)

MTrop commented 2 years ago

false is the default for monsterInfighting, hence the lack of changed output. It may be badly named as to what its function is supposed to be. It maybe should have been called disableMonsterInfighting, but I'm still not sure what it does.

punchyouinthefaceman commented 2 years ago

That was silly of me, it appears to do the opposite of what I thought it did. It makes enemy projectiles hurt monsters regardless of their type (e.g. an Imp can be hurt by an Imp fireball) and allows monsters of the same type to infight. Whacked4 refers to the parameter as "Monsters fight own species" which seems more clear.

MTrop commented 2 years ago

I'll have to create an alias or secondary name for it like monstersFightSameSpecies and still keep around the old name just for older DECOHack code. I'll have to change the documentation for the newer name.

MTrop commented 2 years ago

Added as monstersFightOwnSpecies.

Added in commit e80073cce2a339997c5542f8e32dc402fcfb952c.