MTry / homebridge-smart-irrigation

Turn any electrical irrigation valve into a smart-valve.. or run your pumps on a smart schedule based on your climate! This homebridge plugin exposes a multi-zone irrigation sprinkler dummy control system to Apple's HomeKit. Although a dummy, it brings smarts of an evapotranspiration based climate and plant adaptive irrigation controller with the use of OpenWeatherMap API. The plugin can optionally email you, and/or send you push notifications through Pushover or Pushcut, with the watering schedule it has calculated, or when a watering run is completed, along with the next 7-day weather forecast. Added option to expose system controls to Homekit allowing a user to enable/disable irrigation, rechecks, push and email notifications from within the Home App. Associated WaterLevel Characteristic shows the % of watering cycle remaining.
MIT License
78 stars 3 forks source link

[BUG] #41

Open AscendK2 opened 1 year ago

AscendK2 commented 1 year ago

Thank you for developing an amazing product that integrates weather science and crop science to save water.

Describe the bug OpenWeatherMap.org has recently migrated from their call API protocol 2.5 to 3.0 The API keys they are now handing out with 1000 free calls per day only work with the API 3.0 protocol and one has to pay for a plan that works with the 2.5 protocol. New keys issues by OpenWeatherMap produce a 401 error when trying to pull weather data as the syntax of the call is incorrect.

To Reproduce 1) Open a new OpenWeatherMap.org "One Call API 3.0" subscription. Place the key into Homebridge-Smart-Irrigation and a 401 error will be generated on each call due to the use of "2.5" in the call syntax instead of "3.0"

Expected behavior Successful API call did not occur due to syntax error.

Platform (please complete the following information):

Suggested solution: Add a menu choice in HomebridgeSmartIrrigation-->Settings-->Primary Setup which toggles between API call syntax version 2.5 and 3.0 This will simply swap the numbers "2.5" and "3.0" in the API call syntax. By default it is set to 2.5 to provide compatibility for those current users who signed up for a key under API v2.5 but allows new users to select 3.0 to work with the new keys.

MTry commented 1 year ago

Thank you for pointing this out and the suggestion.. will try this out over the coming weekend and revert with the changes. Hopefully earlier than that if I'm able to find some time for this..

AscendK2 commented 1 year ago

This issue has resolved, no longer getting the error messages, API calls are working now. Thank you.