search

MUCDK / ott

Optimal Transport tools implemented with the JAX framework, to get auto-diff, parallel and jit-able computations.
https://ott-jax.readthedocs.io
Apache License 2.0
0 stars 2 forks source link

Stop needs to be initialized #2

Closed soerenab closed 8 months ago

soerenab commented 8 months ago

Describe the bug stop is not initialized when iter < self.iterations, see here: https://github.com/MUCDK/ott/blob/draft/neural_base_solver/src/ott/neural/flow_models/genot.py#L291

Error than occurs here: https://github.com/MUCDK/ott/issues/new?assignees=&labels=&projects=&template=bug_report.md&title=

To Reproduce Train genot for more than 0 iterations.

Potential fix Initialize stop with False prior to while loop.

soerenab commented 8 months ago

Actually, this applies for both GENOTLin and GENOTQuad.

MUCDK commented 8 months ago

Thanks, pushed it.