MUCollective / multiverse

R package for creating explorable multiverse analysis
https://mucollective.github.io/multiverse/
GNU General Public License v3.0
62 stars 5 forks source link

Issues with Creating EMARs #122

Closed abhsarma closed 2 months ago

abhsarma commented 2 months ago

We want to support export of multiverse analysis to EMARs. While we have a working implementation thanks to @hwangkyle, there are still some pending issues (including #116).

Broadly, this is due to how things are implemented in knitr:

abhsarma commented 2 months ago

For the second issue, I think it can be solved by again providing an optional argument to eng_r to control the behavior of plot_counter() which will almost always be FALSE except for this specific use case. But I am apprehensive of just jumping to this solution. @mjskay thoughts?

mjskay commented 2 months ago

hmm I dunno. What is plot_counter()?

abhsarma commented 2 months ago

It's a knitr internal function but it's not documented / described, so I have no idea---which is why I'm asking

mjskay commented 2 months ago

hmm I dunno, try reading or stepping through the code to figure out what it does? Or ask the knitr folks...

abhsarma commented 2 months ago

the second one seems like is solved by changing the chunk label during knitting to be unique

abhsarma commented 2 months ago

This has been filed as an issue / PR in knitr. See: https://github.com/yihui/knitr/pull/2358 I am hoping this will be fixed when they have updated it on their end, if not it will be reopened.

mjskay commented 2 months ago

As a process suggestion, if this issue is not fixed yet here and is waiting on a change in knitr, I would leave it open so that it is still tracked here (and someone coming along with that problem can find it)