Parser not catching extra coord aes assignments

xiaoyingpu commented 4 years ago

in pgog.Rmd:

ggplot(mtcars) + geom_icon(aes(height = c(P(gear)), x = c(gear, cyl)))
ggplot(mtcars) + geom_icon(aes(height = c(P(cyl|gear), P(gear)), x = c(gear, vs)))

xiaoyingpu commented 4 years ago

This should pass the check but now it doesn't @olivernan

https://github.com/MUCollective/pgog/blob/master/vignettes/pgog.Rmd#L224

ggplot(mtcars) + 
  geom_bloc(aes(
    x = c(mpg), 
    height = c(P(cyl|mpg), P(mpg)), 
    fill = factor(cyl)), bw = common_bw)

Also the build failed

nanyyyyyy commented 4 years ago

Ok, it will look into it

xiaoyingpu commented 4 years ago

I fixed one little thing too so just do a pull onto your branch

On Tue, Jan 28, 2020 at 18:51 olivernan notifications@github.com wrote:

Ok, it will look into it

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MUCollective/pgog/issues/61?email_source=notifications&email_token=AB74SLPV5GYPGZKYQTJWHZDRADAH3A5CNFSM4KEY3ZS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFON6I#issuecomment-579528441, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB74SLM2JJLCMR5RIMB5RGTRADAH3ANCNFSM4KEY3ZSQ .

-- Xiaoying Pu Ph.D. Candidate in Computer Science and Engineering University of Michigan xiaoyingpu.github.io Midwest Uncertainty Collective https://mucollective.northwestern.edu

MUCollective / pgog

Parser not catching extra coord aes assignments #61