search

MUM-Open-Source / eureka-web-app

A responsive web app built on Vue 3 and Firebase that aims to connect members of the MUMTEC academic community with each other and opportunities within the community.
https://eureka-monash.com/
MIT License
9 stars 29 forks source link

feature/notifications #103

Closed weichunnn closed 3 years ago

netlify[bot] commented 3 years ago

✔️ Deploy Preview for eureka-guide ready!

🔨 Explore the source changes: 9388651c6334dfdef7e5f953d06d0f6329d1bb3c

🔍 Inspect the deploy log: https://app.netlify.com/sites/eureka-guide/deploys/610a6ff2a2e04600095d426e

😎 Browse the preview: https://deploy-preview-103--eureka-guide.netlify.app

weichunnn commented 3 years ago

Hi @NitinMa2 , based on your feedback, I had made the necessary changes. Do take a look and let me know if anything is breaking. From my side, everything looks good to me.

  1. Refactored to fix.
  2. Fixed. Modal has a maximum size of 300 px on small screen, hence this wouldn’t be any problem on phone screens.
  3. Need more clarifications on this.
  4. This is working on my machine. Maybe you can point out a case where it’s breaking on yours.
  5. Done
  6. Refactored to show the changed. However, we should consider usability and accessibility (to be more user focused than dev focused) What is the difference between p and div?
  7. Added page pad, however I override the value to reduce wasted spaces
  8. DB structure had been flattened as per our discussion
  9. Done
  10. Done
  11. Done