search

MUME / DecafMUD

DecafMUD is an extensible, translatable MUD client written in JavaScript.
https://decafmud.stendec.me/
MIT License
2 stars 3 forks source link

Provide a default terminal font #4

Open nschimme opened 1 year ago

nschimme commented 1 year ago

DejaVu Sans Mono would be a good thing to bundle and include

nschimme commented 1 year ago

Adobe Source Code Plus seems to be another good candidate: https://github.com/adobe-fonts/source-code-pro

Tiger-Tom commented 1 year ago

On https://github.com/MUME/DecafMUD/blob/master/src/js/decafmud.js#L1877, is there any reason for the DecafMUD.settings object? I cannot find any reference to it later, but I don't want to change anything with fonts because of the line at 1898 (https://github.com/MUME/DecafMUD/blob/master/src/js/decafmud.js#L1898) where "font" is mentioned as a possible configuration option. If this object isn't needed, then may I introduce a pull request to remove it?

Tiger-Tom commented 1 year ago

In relation to the font itself, I believe that Adobe Source Code Plus would be a good candidate, and I will implement it as a default font once https://github.com/MUME/DecafMUD/issues/4#issuecomment-1297596054 has been resolved.

Tiger-Tom commented 1 year ago

Also, Adobe Source Code Plus is a monospaced font, so ASCII art should be retained perfectly.

nschimme commented 1 year ago

Isn't that code for this part of the experience?

image
nschimme commented 1 year ago

I think all we need to do is package the font library and also reference it over what is currently being used by default in the CSS: https://github.com/MUME/DecafMUD/blob/master/src/css/main.css#L245

Okay, maybe not THAT simple: https://github.com/MUME/DecafMUD/search?q=Consolas