search

MUME / MMapper

🧙‍♂️MMapper is a graphical client designed for the MUME (Multi-Users in Middle-earth) game
https://mume.github.io/MMapper/
GNU General Public License v2.0
35 stars 26 forks source link

Modernize Codebase to C++11 #124

Closed nschimme closed 6 years ago

nschimme commented 6 years ago

We need to modernize the codebase to identify bugs.

nschimme commented 6 years ago

Hey Justin,

I'm already working on this particular ticket. If you want to help I would suggest you wait another few weeks.

Best, Nils

On Thu, Jul 26, 2018 at 1:44 PM Justin Richard Key notifications@github.com wrote:

Hello! i don't have much time atm to look over all the code but i did notice few manual destructors. C++11 allows destructors to be automatically called when going out of scope. imo doing something manually when i will occur naturally may lead to future bugs. I just started github and have been practicing code for the past few years, i would like to help update this project.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MUME/MMapper/issues/124#issuecomment-408229401, or mute the thread https://github.com/notifications/unsubscribe-auth/AFQAoVx7rX0m_YAEHIRtcp9h3Td8Pns_ks5uKio_gaJpZM4Vbau2 .

nschimme commented 6 years ago

We should take a look at utilizing clazy (https://github.com/KDE/clazy) to do static analysis on the code and modernize the signals/slots logic.

JustinKey187 commented 6 years ago

That’s fine. Thanks for the heads up!

Sent from my iPhone

On Jul 27, 2018, at 12:33 PM, Nils Schimmelmann notifications@github.com<mailto:notifications@github.com> wrote:

We should take a look at utilizing clazy (https://github.com/KDE/clazy) to do static analysis on the code and modernize the signals/slots logic.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/MUME/MMapper/issues/124#issuecomment-408517991, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARs69RsDxMqlvt1MdMg7XraSx8o2CR_fks5uK2r5gaJpZM4Vbau2.