search

MUnique / OpenMU

This project aims to create an easy to use, extendable and customizable server for a MMORPG called "MU Online".
https://munique.net
MIT License
707 stars 296 forks source link

A Fenrir cannot be repaired with a Jewel of Bless #400

Closed sven-n closed 4 months ago

sven-n commented 8 months ago

Describe the bug A Fenrir cannot be repaired with a Jewel of Bless.

To Reproduce Steps to reproduce the behavior:

  1. Prepare a test account, e.g. testgm or test400 on the admin panel, so that the fenrir has about 100 durability.
  2. Enter the game, login with the account.
  3. Take a Jewel of Bless and drop it on the Fenrir
  4. See that the fenrir didn't get repaired and the Jewel of Bless is still there.

Expected behavior The fenrir should be repaired to 255 durability and the Jewel of Bless should be consumed.

Additional context See https://github.com/MUnique/OpenMU/blob/a8703d1dce1f500277696316b2fed30e2f326164/src/GameLogic/PlayerActions/ItemConsumeActions/BlessJewelConsumeHandlerPlugIn.cs#L18 Currently, it just works by upgrading an item level. Hard coding the fenrir into the ModifyItem method to get the behavior is possible. However, it would be great to be able to define which Item can be repaired by a bless in a configuration. A plugin configuration could be added by implementing ISupportCustomConfiguration<TConfig> and ISupportDefaultCustomConfiguration, but I'm not sure if a lookup for items is possible with the current system.