Closed sven-n closed 4 months ago
Describe the bug A Fenrir cannot be repaired with a Jewel of Bless.
To Reproduce Steps to reproduce the behavior:
testgm
test400
Expected behavior The fenrir should be repaired to 255 durability and the Jewel of Bless should be consumed.
Additional context See https://github.com/MUnique/OpenMU/blob/a8703d1dce1f500277696316b2fed30e2f326164/src/GameLogic/PlayerActions/ItemConsumeActions/BlessJewelConsumeHandlerPlugIn.cs#L18 Currently, it just works by upgrading an item level. Hard coding the fenrir into the ModifyItem method to get the behavior is possible. However, it would be great to be able to define which Item can be repaired by a bless in a configuration. A plugin configuration could be added by implementing ISupportCustomConfiguration<TConfig> and ISupportDefaultCustomConfiguration, but I'm not sure if a lookup for items is possible with the current system.
ModifyItem
ISupportCustomConfiguration<TConfig>
ISupportDefaultCustomConfiguration
Describe the bug A Fenrir cannot be repaired with a Jewel of Bless.
To Reproduce Steps to reproduce the behavior:
testgm
ortest400
on the admin panel, so that the fenrir has about 100 durability.Expected behavior The fenrir should be repaired to 255 durability and the Jewel of Bless should be consumed.
Additional context See https://github.com/MUnique/OpenMU/blob/a8703d1dce1f500277696316b2fed30e2f326164/src/GameLogic/PlayerActions/ItemConsumeActions/BlessJewelConsumeHandlerPlugIn.cs#L18 Currently, it just works by upgrading an item level. Hard coding the fenrir into the
ModifyItem
method to get the behavior is possible. However, it would be great to be able to define which Item can be repaired by a bless in a configuration. A plugin configuration could be added by implementingISupportCustomConfiguration<TConfig>
andISupportDefaultCustomConfiguration
, but I'm not sure if a lookup for items is possible with the current system.