search

MUnique / OpenMU

This project aims to create an easy to use, extendable and customizable server for a MMORPG called "MU Online".
https://munique.net
MIT License
730 stars 314 forks source link

Possible incorrect values sent for C1-25-AppearanceChangedExtended when unequipping #509

Open nitoygo opened 3 hours ago

nitoygo commented 3 hours ago

Describe the bug Unequipping Gear/Pet does not reflect on other player

To Reproduce Steps to reproduce the behavior:

  1. Login 2 players, Player1 and Player2, Player1 with a pet (or any gear equipped)
  2. Player1: Equip Fenrir
  3. // Player2 can see Player1 ride the fenrir
  4. Player1: Unequip Fenrir
  5. // Player2 still see Player1 on a fenrir

Expected behavior From Player2's POV, the fenrir should no longer be visible (Also applies to gear such as armor, wings, etc.)

Additional Context In client side (MuMain 5.2 client), 0xFF is used to detect if the equipment is to be removed image

However, in the logs, the ItemGroup value uses the original value of the item.

nitoygo commented 3 hours ago

Related to: https://github.com/sven-n/MuMain/issues/47