search

MVCoconut / coconut.data

Observable Data Layer.
The Unlicense
20 stars 8 forks source link

Inspect coreType later #40

Closed kevinresol closed 5 years ago

kevinresol commented 5 years ago

I just updated one of my older projects to latest coconut and haxe4 rc1, and then https://github.com/MVCoconut/coconut.data/issues/12 pops up again while it was fine before the upgrade. Dunno what have changed causing the problem. But apparently this patch fixes it.

p.s. My problematic type is an abstract marked with @:pure, otherwise its underlying type is recursive. Since it is not tagged as @:coreType, check(a.type) triggered the recursion. So I moved that after the @:pure check.

back2dos commented 5 years ago

Thanks! Incidentally solved this while cleaning up a bit how abstracts are processed in general :D