MVoz / arora

Automatically exported from code.google.com/p/arora
0 stars 0 forks source link

Tab should bind to next entry in drop down list if location bar is focused #79

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently, writing an url in the url bar pops up a small ff2-like url list. It 
would really be great if tab 
was bound to the next url entry (and shift tab to previous one), the current 
implementation (only 
arrow keys) is very disturbing to use on a laptop.

Original issue reported on code.google.com by adys...@gmail.com on 4 Jun 2008 at 6:56

GoogleCodeExporter commented 9 years ago

Original comment by ice...@gmail.com on 4 Jun 2008 at 10:56

GoogleCodeExporter commented 9 years ago

Original comment by ice...@gmail.com on 1 Aug 2008 at 9:41

GoogleCodeExporter commented 9 years ago
I've always hated that feature, actually. The tab key is supposed to go to the 
next focus entry, not cycle a 
selection. Why should the completion bar behave differently than any other 
auto-completion feature in 
most applications, or differently than the very combo box that led to its 
invention?

If the arrow keys already work, breaking the functionality of another key seems 
a tad ill-advised.

Original comment by chighl...@gmail.com on 5 Aug 2008 at 7:39

GoogleCodeExporter commented 9 years ago
I agree with chighland.

Original comment by inetper...@gmail.com on 14 Aug 2008 at 3:21

GoogleCodeExporter commented 9 years ago

Original comment by ice...@gmail.com on 30 Sep 2008 at 5:16

GoogleCodeExporter commented 9 years ago
I complete agree with this bug.
I think the ideal behaviour would be copied from firefox.
Their behaviour is:
* if text entered in location bar, drop down appears, tab will cycle through 
them.
* pressing escape gets rid of drop-down, and pressing tab will now make focus 
go to the search box.

From a brief test, a number of appications exhibit the same behaviour.

I think the worst part of the current behaviour is it forces the user to take 
their hands away from the 
"home" keys.

Original comment by Lex.Hi...@gmail.com on 22 Aug 2009 at 4:53

GoogleCodeExporter commented 9 years ago
Just my 2 cents as a regular user of arora - if the tab key is overloaded as 
suggested, then how to you get over to the search 
box, for instance? I would rather keep the current behavior.

Original comment by phale...@gmail.com on 19 Sep 2009 at 10:43

GoogleCodeExporter commented 9 years ago
phalenor: You can get to the search box using Ctrl+K.  I don't believe that I 
have ever intentionally used the current tabbing behaviour to access the search 
box instead of going there directly.

If I'm ever focusing the location bar or search box (the latter increasingly 
rare for me now that keywords let me search from the location bar) then it's a 
conscious action with rather specific 
goals in mind.  If I've hit Ctrl+L then I've already shifted gears and 
absolutely don't want to be interracting with the rest of the browser until 
I've done what I set out to do or change my mind and 
cancel (using escape).

Original comment by tj.robot...@gmail.com on 19 Sep 2009 at 11:41

GoogleCodeExporter commented 9 years ago
http://github.com/Arora/arora/commit/d48363e0c08c683c345d036e35fdcf22b50df7e4

Original comment by ice...@gmail.com on 30 Sep 2009 at 3:18

GoogleCodeExporter commented 9 years ago
 tj.robotham: ctrl+k isn't exactly intuitive. My typical workflow involves ctrl+t to
open a new tab, then tab to get over to the search box. I see that's broken in 
0.10
now =/ I wonder if anyone else cares. I guess we'll soon find out.

Original comment by phale...@gmail.com on 1 Oct 2009 at 1:05

GoogleCodeExporter commented 9 years ago
phalenor: It was my work that traps tab in the url bar. I think that it can be
extended to only go through possible completions when the completion menu has 
popped up.

So if there is no popup, the tab press will change the focus. This is the 
behaviour
of Firefox.

Original comment by evilsud...@hotmail.com on 1 Oct 2009 at 7:53

GoogleCodeExporter commented 9 years ago
Yah that tabbing should have only applied when the completer was opened.  Fixed 
that:

http://github.com/Arora/arora/commit/ad1852ef4d7e74f38fdb0645919bf580da14dfc7

Original comment by ice...@gmail.com on 2 Oct 2009 at 4:53