MW-Peachy / Peachy

The official MediaWiki PHP bot framework. Current Version: 2.0 alpha 8
GNU General Public License v3.0
26 stars 21 forks source link

Bug: Error when editing page named "@" #89

Open wahrani opened 9 years ago

wahrani commented 9 years ago

Why it's not possible to edit a page named @ ?

the result is many warnings (Warning: API is not responding, retrying...) and finally an exception (PHP Fatal error: Uncaught exception 'MWAPIError' with message 'API Error: noresponse )

cyberpower678 commented 9 years ago

That is the fault of the API and not peachy by the sound of it. Peachy isn't receiving a response from the API? Can you submit the relevant POST/GET entries from the POST/GET log?

Gesendet von Maximilian's iPhone. (Sent from Maximilian's iPhone.)

On Mar 12, 2015, at 10:05, wahrani notifications@github.com wrote:

Why it's not possible to edit a page named @ ?

the result is many warnings (Warning: API is not responding, retrying...) and finally an exception (PHP Fatal error: Uncaught exception 'MWAPIError' with message 'API Error: noresponse )

— Reply to this email directly or view it on GitHub.

wahrani commented 9 years ago

if it is the fault of the API , why the same work is done with pywikipedia !!

wahrani commented 9 years ago

the solution is to use pageid in place of title :

Replace Page.php line 1172: 'title' => $this->title, With 'pageid' =>$this->pageid,

cyberpower678 commented 9 years ago

I'd still like to see some communication data. Peachy generates them by default.

Gesendet von Maximilian's iPad. (Sent from Maximilian's iPad.)

On Mar 12, 2015, at 11:44, wahrani notifications@github.com wrote:

the solution is to use pageid in place of title :

Replace Page.php line 1172: 'title' => $this->title, With 'pageid' =>$this->pageid,

— Reply to this email directly or view it on GitHub.

wahrani commented 9 years ago

Method: POST URL: http://myserver/w/api.php (Parameters masked for security) Raw Data: UNSERIALIZATION FAILED

danmichaelo commented 9 years ago

If this was an inherit API issue, it should manifest itself in mwclient as well. I gave it a test, but failed to reproduce the problem. Is it possible that it was just caused by some temporary server issue?

Also, it seems to me like pywikipedia uses title as well.

cyberpower678 commented 9 years ago

That is very well possible. I need to do some looking first.

On Mar 15, 2015, at 08:55, Dan Michael O. Heggø notifications@github.com wrote:

I wanted to test if this was an issue with mwclient https://github.com/mwclient/mwclient, but I failed https://no.wikipedia.org/w/index.php?title=@&diff=prev&oldid=13755177 to reproduce the problem. Is it possible that it was just caused by some temporary server issue?

Also, it seems to me like pywikipedia uses title https://git.wikimedia.org/blob/pywikibot%2Fcore.git/34eac312d0f77075c18ded956b863dff0af4a16a/pywikibot%2Fsite.py#L4137 as well.

— Reply to this email directly or view it on GitHub https://github.com/MW-Peachy/Peachy/issues/89#issuecomment-80998222.

wahrani commented 9 years ago

@danmichaelo these error where generated on wikipedia server and also on a local server (no charge no problem).