Closed shmookey closed 1 year ago
Merging #134 (bc79d70) into main (d97ed01) will decrease coverage by
0.25%
. The diff coverage is90.93%
.:exclamation: Current head bc79d70 differs from pull request most recent head 4adf03e. Consider uploading reports for the commit 4adf03e to get more accurate results
@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 95.67% 95.43% -0.25%
==========================================
Files 13 13
Lines 7613 7888 +275
==========================================
+ Hits 7284 7528 +244
- Misses 329 360 +31
Impacted Files | Coverage Δ | |
---|---|---|
src/error.rs | 100.00% <ø> (ø) |
|
src/lib.rs | 25.00% <0.00%> (-75.00%) |
:arrow_down: |
src/cli.rs | 96.94% <90.64%> (-0.71%) |
:arrow_down: |
src/main.rs | 90.62% <91.46%> (+2.16%) |
:arrow_up: |
src/io/mod.rs | 80.79% <100.00%> (+0.30%) |
:arrow_up: |
src/preprocessing.rs | 98.28% <100.00%> (ø) |
|
src/test_common.rs | 85.73% <100.00%> (+0.75%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hey Luke. I've got Dev here and we were just talking about your code here. Given the time pressures in place, I think this absolutely fine to push out (and good job on getting it working). I made some comments on the code, mostly as a way to maybe help you identify places that make you a better Rust programmer but also fight any technical debt that Birli might be accruing. As Birli is a dep of hyperdrive, I do hack on Birli from time to time, so from that perspective I have time to give if you want to sit down and improve things.
Includes new command-line option
--sel-chan-ranges
and automatic detection of picket fenced inputs