MWATelescope / Birli

A Rust library for preprocessing tasks in the Murchison Widefield Array (MWA) data pipeline.
Mozilla Public License 2.0
16 stars 3 forks source link

Mwaf overhaul #89

Closed cjordan closed 2 years ago

cjordan commented 2 years ago

Please see the commit messages for more info.

cjordan commented 2 years ago

Ah crap I forgot to update the changelog. Will force push later.

codecov[bot] commented 2 years ago

Codecov Report

Merging #89 (595320f) into main (4fac109) will increase coverage by 0.07%. The diff coverage is 95.67%.

:exclamation: Current head 595320f differs from pull request most recent head 387de4e. Consider uploading reports for the commit 387de4e to get more accurate results

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   95.36%   95.44%   +0.07%     
==========================================
  Files          14       14              
  Lines        6967     7413     +446     
==========================================
+ Hits         6644     7075     +431     
- Misses        323      338      +15     
Impacted Files Coverage Δ
src/io/error.rs 50.00% <ø> (+50.00%) :arrow_up:
src/lib.rs 100.00% <ø> (ø)
src/io/mwaf.rs 95.65% <94.59%> (-0.57%) :arrow_down:
src/flags.rs 99.10% <98.36%> (+0.22%) :arrow_up:
src/cli.rs 97.66% <100.00%> (+0.11%) :arrow_up:
src/corrections.rs 99.50% <100.00%> (+<0.01%) :arrow_up:
src/io/mod.rs 80.25% <100.00%> (ø)
src/preprocessing.rs 98.28% <100.00%> (-0.05%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fac109...387de4e. Read the comment docs.

cjordan commented 2 years ago

Do we want Birli to overwrite existing flag files? It currently panics if a destination flag file exists.

d3v-null commented 2 years ago

Do we want Birli to overwrite existing flag files? It currently panics if a destination flag file exists.

Yeah I think overwriting is a good default.

cjordan commented 2 years ago

For posterity, I accidentally closed this PR. The work continues in PR #93.