search

MWATelescope / giant-squid

An alternative MWA ASVO client
Other
6 stars 1 forks source link

Added voltage download submission option. Fixes #12 #13

Closed gsleap closed 1 year ago

gsleap commented 1 year ago

Hi folks,

My first PR for Giant Squid! This allows the submission of voltage jobs. NOTE the server will reject a request if you are not in the mwavcs or mwaops MWA ASVO pawsey group.

Cheers

Greg

codecov[bot] commented 1 year ago

Codecov Report

Merging #13 (2648813) into main (5821085) will increase coverage by 0.64%. The diff coverage is 43.02%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   38.04%   38.68%   +0.64%     
==========================================
  Files           8        8              
  Lines        1033     1114      +81     
==========================================
+ Hits          393      431      +38     
- Misses        640      683      +43
Files Changed Coverage Δ
src/asvo/error.rs 0.00% <ø> (ø)
src/bin/giant-squid.rs 0.32% <0.00%> (-0.06%) :arrow_down:
src/asvo/mod.rs 45.23% <86.04%> (+6.02%) :arrow_up:

... and 1 file with indirect coverage changes

cjordan commented 1 year ago

I'm not really looking at giant-squid any more, but your PR looks good :+1: I trust you've tested this and it works to your sanctification. Maybe Dev would like to cast their eyes over the code, but I reckon you can merge and release as you please.