search

MWATelescope / giant-squid

An alternative MWA ASVO client
Other
6 stars 1 forks source link

Download does not check if destination is writeable (or return error code) #6

Closed d3v-null closed 1 year ago

d3v-null commented 1 year ago

When using giant-squid download, no check is made that the directory where the .tar is written or unpacked is writable. It downloads the tar file to... nowhere, and then exits without any issues.

This is an issue when you accidentally forget to mount your current directory in the singularity bind path.

example:

$ mkdir unwritable
$ cd unwritable/
$ chmod ugo-rx .
# test it is in fact, unwritable
$ touch test
touch: cannot touch 'hi': Permission denied
$ giant-squid download --keep-zip $jobid
$ echo $?
0