search

MWATelescope / giant-squid

An alternative MWA ASVO client
Other
6 stars 1 forks source link

actually handle io errors if they occur #7

Closed d3v-null closed 1 year ago

d3v-null commented 1 year ago

fixes #6

error message looks like this:

mkdir unwritable; cd unwritable; chmod a-wx .
giant-squid download --keep-zip 656095; cd ..; rm -rf unwritable
16:46:47 [INFO] Downloading ASVO job ID 656095 (obsid: 1363257760, type: Conversion, 10.0 GiB)
Error: Permission denied (os error 13)

Caused by:
    Permission denied (os error 13)
codecov[bot] commented 1 year ago

Codecov Report

Merging #7 (18ddffc) into main (8baab62) will decrease coverage by 0.79%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   38.90%   38.11%   -0.79%     
==========================================
  Files           8        8              
  Lines        1023     1031       +8     
==========================================
- Hits          398      393       -5     
- Misses        625      638      +13
Impacted Files Coverage Δ
src/asvo/mod.rs 39.20% <0.00%> (-0.98%) :arrow_down:

... and 1 file with indirect coverage changes