search

MWATelescope / mwalib

Library to read Murchison Widefield Array (MWA) raw visibilities, voltages and metadata into a common structure
Mozilla Public License 2.0
10 stars 2 forks source link

CoarseChannel.corr_chan_number not correct when only accessing subset of channels #24

Closed gsleap closed 3 years ago

gsleap commented 3 years ago

Example: I have the following gpubox files, which consist of 2 coarse channles: "1297526432_mwax/1297526432_20210216160014_ch117_000.fits", "1297526432_mwax/1297526432_20210216160014_ch117_001.fits", "1297526432_mwax/1297526432_20210216160014_ch118_000.fits", "1297526432_mwax/1297526432_20210216160014_ch118_001.fits" These coarse channels represent the 9th and 10th (or 8th and 9th if zero indexed).

mwalib will set the corr_chan_number for 117 to be 0 and 118 to be 1. But this is not correct. The corr_chan_number should not change whether we have all or a subset of channels.

gsleap commented 3 years ago

This is not an issue. The example I had does indeed provide 0 and 1 as the corr_chan_number values, but I was testing using a hacked metafits which caused the results to not be what I would expect from a "real" metafits (which would be 8 & 9)