Closed cjordan closed 1 year ago
Patch coverage: 90.13%
and project coverage change: -0.09%
:warning:
Comparison is base (
d7ff687
) 96.50% compared to head (4d6f1de
) 96.42%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is not ready to be merged!
This commit contains code that could allow
pymwalib
to be deprecated. Work to do and considerations:mwalib
and can't bepymwalib
(it needs to match the name of the Cargo package)pymwalib
examples over, but they currently don't work because (1) imports need to be updated and (2) there are other differencescheck_mwalib_version
function shouldn't be needed anymore; no libmwalib.so file is needed to run the pyo3 Python code.maturin develop --release -b pyo3 --features=python --strip
)maturin
(the Python tool used to install the Rust code as a Python package) likes you to have a pyproject.toml file (or something like this); this should be added.CorrelatorContext
should be good to go, but I haven't put in any work forVoltageContext
So, there's a lot of stuff to be done, but, it should mean less work long term because
pymwalib
needs to be kept in sync withmwalib
.