MWDelaney / bootstrap-3-shortcodes

WordPress shortcodes for easier use of Bootstrap elements in your content.
https://wordpress.org/plugins/bootstrap-3-shortcodes/
MIT License
377 stars 118 forks source link

Bootstrap Shortcodes Help #19

Closed jeffreysfridge closed 11 years ago

jeffreysfridge commented 11 years ago

Whenever I click the "Bootstrap Shortcodes Help" button it pulls up a blank iframe.

MWDelaney commented 11 years ago

See https://github.com/filipstefansson/bootstrap-shortcodes#installation

If you download the .zip file from GitHub it fails to include a required submodule.

vinefreeman commented 11 years ago

if you clone the repo it also gives the same error.

MWDelaney commented 11 years ago

The required submodule, https://github.com/michelf/php-markdown, requires PHP 5.3 or later. Can you check your PHP version, and any error_logs that might have useful information?

vinefreeman commented 11 years ago

Thanks FoolsRun, I've decided against it as the requirement of further bits out of my control leaves me uneasy...

MWDelaney commented 11 years ago

It's a good practice to run a modern version of PHP anyway. We included php_markdown as a sub module to make keeping this plugin up to date and secure easier. We're sorry you won't be using it.

vinefreeman commented 11 years ago

Thanks... I'm running PHP 5.3. It's just that as I don't really know what's going on (with markdown) I don't want to add something that could cause me probs (and I would hve no control over, too many dependencies etc). Your plugin looks great though and I was gutted when I couldn't use it.

simonyeldon commented 11 years ago

The php_markdown is only required if viewing the help.

Maybe we should look at making this an optional feature (a check box on the plugin settings maybe?)

vinefreeman commented 11 years ago

Yes, i'm getting the error when clicking the button on the write panel editor (TinyMCE etc...)

MWDelaney commented 11 years ago

I think this is an unusual request and case. Plugins like this one use dependencies all the time. This one requires Bootstrap and jQuery in addition to php_markdown. php_markdown is open source right here on GitHub and the user can review its source code if he is suspicious of it.

I included php_markdown as an easy way of keeping the user-viewable help up to date with the repository's README (by making them literally the same document). Since this project has only a few maintainers, it seemed the easiest way to not have to write everything twice. If we no longer think this is a good plan we can definitely revisit the issue.

MWDelaney commented 11 years ago

@vinefreeman can you describe what error you receive? The original issue didn't describe an error, only a blank ThickBox popup.

vinefreeman commented 11 years ago

hi guys... when clicking the shortcode help button on the write panel editor, the pop-up window contained lots of errors... to do with the markdown plugin... I'm not massively technical, but I forked the repo and installed that way (not manually).

MWDelaney commented 11 years ago

can you copy the errors into a comment here? Seeing them would help us diagnose whether the issue is with our plugin, or upstream with php_markdown.

vinefreeman commented 11 years ago

Will do - I just need to get a project live then I'm moving onto the one this plugin was needed for... I must admit i would prefer to use your plugin.

vinefreeman commented 11 years ago

Hi guys I'm slightly confused now. Have just cloned the bootstrap-shortcodes git and am getting different errors (when clicking the 'B' in the editor), it's bascially saying there's a missing include. So I looked in the markdown folder in bootstrap-shortcodes/includes foler and the markdown folder is now empty. Also in WP BS3 shortcodes plugin, it's saying there is a newer version available but I cloned from github - is this not the most recent ver?

Do i need to clone the markdown git separately? The install on your readme tends to suggest that is part of the manual process.

Apologies if I'm being an idiot.

MWDelaney commented 11 years ago

I can answer the Wordpress Update part right now --I'll investigate the cloning issue later on.

WordPress uses the plugin's folder name to determine whether updates are available. Unfortunately there are a lot of plugins named similarly to ours, which is why we recently changed the name to "bootstrap-3-shortcodes".

My guess is that your plugin folder is named "bootstrap-shortcodes" or something similar which overlaps with another plugin in the WordPress repository. Can you check that and rename your folder if necessary? That should clear up the incorrect update notification.

vinefreeman commented 11 years ago

thanks i've renamed the folder and that has cleared the WP message

MWDelaney commented 11 years ago

I've just deleted and re-cloned using the GitHub GUI client and it also cloned the submodule successfully.

If you are cloning the repository via command-line, the readme includes additional commands you need to run to get the necessary submodule:

$ git clone git@github.com:filipstefansson/bootstrap-shortcodes.git
$ cd bootstrap-shortcodes/
$ git submodule init
$ git submodule update
vinefreeman commented 11 years ago

Thanks although I don't want this to be a submodule. It's not currently residing in a repo. I only have the theme as a repo not the whole WP structure. Is the last line neccessary to update the markdown requirement?

vinefreeman commented 11 years ago

@FoolsRun ignore my previous comment. It's probably my lack of git knowledge. I had no idea what the submodule section did so avoided it as I didn't think the BS3 shortcodes was a submod - I understand the phpmdown is. Apologies for the running around and thanks for your help.

Is there a way I can edit the conents of the popup window to remove the first section - it might scare my client if they see that...

thanks again.

vinefreeman commented 11 years ago

Hi again - with a couple of the shortcodes I'm getting the following error: screen

Also once I close the modal then open it again, it will not close.

thanks

MWDelaney commented 11 years ago

Where does that error appear? It's not clear from context. What is your hosting situation? Which shortcode caused that error?

vinefreeman commented 11 years ago

Hey - it's on wamp localhost. It appeared for popover and tooltip. And the modal window wouldn't close 2nd time. Php 5.3

MWDelaney commented 11 years ago

Alrighty, there was actually a bug in popover which I've fixed. You can re-download the full plugin, with the necessary submodules (and the scary installation section removed from the README) at this plugin's new page here:

http://filipstefansson.com/bootstrap-3-shortcodes/

The big scary error you're getting seems to imply a problem with your WAMP setup. domDocument is interpreting <

as

&lt;

And naturally failing to understand it as XML. I'm not sure how to troubleshoot this error. Do you have hosting somewhere that you could try installing the plugin on to confirm it works elsewhere?

vinefreeman commented 11 years ago

thanks - I've now uploaded to a remote test server but unfortunately it is running PHP v 5.2.17. This must be why i'm getting the empty popup window when hitting the 'B' shortcode help button?

MWDelaney commented 11 years ago

This is a server configuration issue, not one with this plugin specifically. Closing.