search

MWDelaney / bootstrap-3-shortcodes

WordPress shortcodes for easier use of Bootstrap elements in your content.
https://wordpress.org/plugins/bootstrap-3-shortcodes/
MIT License
377 stars 118 forks source link

Includes a composer.json file for dependency management through Composer #62

Closed brandensilva closed 10 years ago

brandensilva commented 10 years ago

Hopefully you'll choose to accept this pull request, but this should make dependency management a bit easier for everyone who uses Composer to track their wordpress plugins. For those who don't use Composer, they can simply ignore the file or delete it.

image

I've included two requirements for the composer.json file:

  1. PHP 5.3.2. Feel free to lower or higher the version requirements to fit the adequate version needed for this plugin.
  2. composer/installers so the plugin installs properly to the wordpress plugins directory when ran with Composer Install.

It may be wise to include wordpress as a requirement as well but I'll leave that up to you.

You may also want to submit your plugin to Packagist so others can enjoy your work and install this via Composer with ease.

MWDelaney commented 10 years ago

@simonyeldon and @filipstefansson, do you have any opinions on this?

simonyeldon commented 10 years ago

Apart from the comment on the file it looks good. Composer is the way forwards, and I primarily use the this plugin with Roots. A quick google reveals this over on the roots site http://roots.io/wordpress-plugins-with-composer/, and the composer file seems to follow the recommendation.

Happy to merge once the new line is added at the end.

brandensilva commented 10 years ago

Yeah I use composer with roots.io as well and it makes plugin management a much easier ordeal so I don't have to submit all the plugins to my git repo. One day maybe wordpress will go this route as well and enhance their plugins module.

If you would like, you can also submit BS3 shortcodes to packagist.org site too so its available via the Composer Search command.