search

MWDelaney / bootstrap-3-shortcodes

WordPress shortcodes for easier use of Bootstrap elements in your content.
https://wordpress.org/plugins/bootstrap-3-shortcodes/
MIT License
377 stars 118 forks source link

Notices everywhere #71

Closed antorome closed 10 years ago

antorome commented 10 years ago

Hello

you are often using this

     $return .= ($data_props) ? ' ' . $data_props : '';

If no data_props is set we get many "notice" in logs. May be this would be better

$return .= (!empty($data_props)) ? ' ' . $data_props : '';

What do you think?

MWDelaney commented 10 years ago

Are you running the latest version of the plugin? We've recently rewritten things to remove that kind of error.

antorome commented 10 years ago

yes, just cloned it before creating the issue. check it with these shortcodes http://pastebin.com/HaVf2LK4

and I get Notice: Undefined variable: data_props in /Users/..../wp-content/plugins/bootstrap-3-shortcodes/bootstrap-shortcodes.php on line 135

On Sat, Mar 8, 2014 at 2:02 PM, FoolsRun notifications@github.com wrote:

Are you running the latest version of the plugin? We've recently rewritten things to remove that kind of error.

— Reply to this email directly or view it on GitHubhttps://github.com/filipstefansson/bootstrap-3-shortcodes/issues/71#issuecomment-37097054 .

MWDelaney commented 10 years ago

@antorome, Line 135 in the latest version of the plugin is a comment (see here, and the code you reference in your first comment doesn't appear anywhere in the latest version.

Can you confirm that you cloned from this repo: https://github.com/filipstefansson/bootstrap-3-shortcodes ?

antorome commented 10 years ago

My mistake then... I forked your project https://github.com/antorome/bootstrap-3-shortcodes this weekend but it is forking v3.0.2, don't know why...

On Mon, Mar 10, 2014 at 2:30 PM, FoolsRun notifications@github.com wrote:

@antorome https://github.com/antorome, Line 135 in the latest versinon of the plugin is a comment (see herehttps://github.com/filipstefansson/bootstrap-3-shortcodes/blob/master/bootstrap-shortcodes.php#L135, and the code you reference in your first comment doesn't appear anywhere in the latest version.

Can you confirm that you cloned from this repo: https://github.com/filipstefansson/bootstrap-3-shortcodes ?

— Reply to this email directly or view it on GitHubhttps://github.com/filipstefansson/bootstrap-3-shortcodes/issues/71#issuecomment-37181701 .

antorome commented 10 years ago

Updated and I am having it now here Notice: Undefined index: active in /wp-content/plugins/bootstrap-3-shortcodes/bootstrap-shortcodes.php on line 1189

MWDelaney commented 10 years ago

Hi, can you paste the shortcodes that are producing this notice for you? Thanks!

MWDelaney commented 10 years ago

This should be fixed by cbfec21e0c22e0b33767a80e973597a5160843d0