search

MWDelaney / sage-acf-wp-blocks

Composer library for generating ACF Gutenberg blocks from templates. Intended for use with Roots/Sage (http://roots.io)
346 stars 66 forks source link

Align and SupportsAlign have no effect #24

Open gscr opened 5 years ago

gscr commented 5 years ago

My custom blocks load and save but it seems like the Align and SupportsAlign options have no effect. I am new to gutenberg but am I right in saying SupportsAlign: false should disable the alignment options in the block editor?

bebjakub commented 4 years ago

@MWDelaney could you create a new package release for include those changes? Thank you!

luukskeur commented 4 years ago

@bebjakub This is already added to the core files with this PR: https://github.com/MWDelaney/sage-acf-wp-blocks/pull/26.

This issue can be closed.

bebjakub commented 4 years ago

@luukskeur thanks. I see now. I'll require dev-master

tedw commented 4 years ago

FYI SupportsAlign: false isn’t having any effect for me in WP v5.4.1

{{--
  Title: Example block
  Category: mycategory
  Icon: align-right
  Keywords: example
  Mode: auto
  PostTypes: page post custom-post-type
  SupportsAlign: false
  SupportsMultiple: true
--}}

I’ve enabled “wide” and “full” alignments using add_theme_support('align-wide'); but removing that doesn’t seem to make a difference.

This isn’t a major issue for me, just wanted to mention it in case it’s an easy fix. Thanks so much for your work on this plugin, it’s great!

bebjakub commented 4 years ago

Hi, SupportsAlign: false should just hide align options in the block... for more info refer to acf_register_block_type

intelligence commented 3 years ago

Noticed that if I set:

Align: full
SupportsAlign: false

It won't show the block as full width


But if I set:

Align: full
SupportsAlign: full

It shows the block full width (and the align toggle is shown, with full as the only option)