MWSE / MWSE

Morrowind Script Extender v2
https://mwse.github.io/MWSE/
GNU General Public License v2.0
114 stars 37 forks source link

The peculiar case of the stave named readiedWeapon. #328

Closed DuskWulf closed 2 years ago

DuskWulf commented 3 years ago

Okay, so... Testing environment and methodology!

(Don't feel bad for Adryn, he deserves it.)

Meanwhile, tes3.getEquippedItem() returns the correct weapon like a champ, every time. That was the behaviour I was expecting with checking readiedWeapon so I might just be being stupid. It seems to be the behaviour expected by other mods too though so I... might not be stupid? I never can tell. Sorry.

Suggestion: If you do have to update readiedWeapon to fix some bugs, could you pop in hand-to-hand support? Perhaps returning -1? It'd make me feel safer than just checking for not readiedWeapon, which lead to staves being classified as readiedWeapon and thust he beginning of this grand adventure. Maybe have it return -1 for hand-to-hand? I don't know. I mean, perhaps nil works just as well. Could also be out of scope as it might break other things, so I'd understand that.

Also, I appreciate your hard work! Also, also—I did a bug report despite my social anxiety, NullCascade! I hope it's okay.

C3pa commented 3 years ago

If you want help with your issue, please post code demonstrating your issue, and also post your mwse.log file.

Consider asking your question in MWSE's channel on MMC's discord server. You can join this server here. Asking your question there will ensure you get your issue sorted out quickly.