[Insight] Symfony controller action method should not be too long

MWSimple / AdminCrudBundle

AdminCrud genera un controlador muy básico para una Entity dada. Este controlador extiende e implementa un controlador Super Genial.

http://www.tecspro.com.ar

20 stars 13 forks source link

[Insight] Symfony controller action method should not be too long #88

Open gonzaloalonsod opened 8 years ago

gonzaloalonsod commented 8 years ago

28% of all actions have more than 20 lines. This violation is raised when more than 10% actions are too long.

34 lines for BackendController::ajaxEnabledDisabledAction() in Controller/BackendController.php, line 30

24 lines for DefaultController::updateAction() in Controller/DefaultController.php, line 410

21 lines for DefaultController::createAction() in Controller/DefaultController.php, line 209

Posted from SensioLabsInsight